From 1a2eb532cec4b5f0a4b295554b3c73ae9f7fff3a Mon Sep 17 00:00:00 2001 From: Aarni Koskela Date: Mon, 13 Feb 2023 15:38:27 +0200 Subject: [PATCH] Fix return value check for subprocess.run (#10972) Subprocess.run does not return an integer. Regressed in #10944 --- utils/general.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/general.py b/utils/general.py index 4e5c714..01f0a3b 100644 --- a/utils/general.py +++ b/utils/general.py @@ -631,8 +631,8 @@ def download(url, dir='.', unzip=True, delete=True, curl=False, threads=1, retry for i in range(retry + 1): if curl: s = 'sS' if threads > 1 else '' # silent - r = subprocess.run(f'curl -# -{s}L "{url}" -o "{f}" --retry 9 -C -'.split()) - success = r == 0 + proc = subprocess.run(f'curl -# -{s}L "{url}" -o "{f}" --retry 9 -C -'.split()) + success = proc.returncode == 0 else: torch.hub.download_url_to_file(url, f, progress=threads == 1) # torch download success = f.is_file()